fix: updating connect params and avoiding pointers #759
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just started to experience an issue where my "connect" function wasn't getting called in objective-c. Aftering some debugging, I realized that it was caused by the implementation of BOOL * instead of BOOL
VS
In Objective-C, BOOL is a primitive, not a pointer. Using BOOL * (a pointer) is incorrect unless handling pointers, which we're not doing here. I'm thinking that the BOOL * type may confuse the RN bridge, causing it to drop the method call silently?
And then another change is the default param of
encodingParameters
from the js should be a dict not null.