Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set hailo build library path #15167

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Set hailo build library path #15167

merged 1 commit into from
Nov 25, 2024

Conversation

NickM-27
Copy link
Collaborator

@NickM-27 NickM-27 commented Nov 24, 2024

Proposed change

Sets the LD_LIBRARY_PATH with the hailo driver location

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code
  • Documentation Update

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • The code has been formatted using Ruff (ruff format frigate)

Copy link

netlify bot commented Nov 24, 2024

Deploy Preview for frigate-docs ready!

Name Link
🔨 Latest commit d3a110a
🔍 Latest deploy log https://app.netlify.com/sites/frigate-docs/deploys/6743b8979b5e780008896564
😎 Deploy Preview https://deploy-preview-15167--frigate-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@NickM-27 NickM-27 merged commit 33957e5 into dev Nov 25, 2024
12 of 13 checks passed
@NickM-27 NickM-27 deleted the hailo-library-path branch November 25, 2024 02:07
@sairon
Copy link

sairon commented Nov 25, 2024

@NickM-27 This is IMO more complicated that it needs to be - the fact it's in the /rootfs folder is probably an unintentional side-effect of refactoring from 27ef661. The better fix would be to simply extract the library to the correct folder (where it was located before the above change, i.e. drop the -C /rootfs). I was just about to submit a PR with that fix, when I noticed it was addressed by this PR.

Let me know what you think, I'll be glad to open a PR with the alternative fix.

@NickM-27
Copy link
Collaborator Author

NickM-27 commented Nov 25, 2024

Seems reasonable to me 👍

Please add Blake as a reviewer of that just to be sure

@blakeblackshear
Copy link
Owner

That's correct. It shouldn't end up under /rootfs in the final image. Let me know if I need to fix something upstream in my forked repo of hailort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants