feat: add name and (exact) email fields to user search #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <div class="avatar avatar-64"> | ||
| <img ng-src="{{match.model.avatar_url}}" width="64" /> | ||
| </div> | ||
| <span bind-html-unsafe="match.label | typeaheadHighlight:query"></span> |
There was a problem hiding this comment.
Won't this allow for html injection if the username contains html chars? Maybe we should escape the username or restrict it to ^[a-zA-Z0-9\-_]+$ in the User model
There was a problem hiding this comment.
The module handles the escaping for you. This is what's recommended in their documentation. It's an unsafe bind because they add strong tags around the username.
It's worth noting that the highlighting only works on the username, not their full name. Not sure how to make that work.
Add a few unit tests to verify expected behavior of the test.
|
@blaskovicz Updated |
blaskovicz
added a commit
that referenced
this pull request
Apr 29, 2015
feat: add name and (exact) email fields to user search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Didn't have much time to hack tonight. All I got done was the search with an avatar and their real name.
Addresses issue #15 and partly addresses #19