Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use valid_parameter_keys middleware interface #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use valid_parameter_keys middleware interface #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions lib/excon/addressable.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,16 @@
# creating a request, or connection object. Excon does not enforce this yet, but
# it does print a warning, so this makes things future-proof.
module Excon
VALID_REQUEST_KEYS << :expand
VALID_CONNECTION_KEYS << :expand

module Addressable
# Middleware
#
# Parses a Templated URI string and merges it with the provided variables.
#
class Middleware < Excon::Middleware::Base
def self.valid_parameter_keys
[:expand]
end

def request_call(datum)
# we need to convert a query hash (or string) to the proper format for
# Addressable to work with. We also need to remove the `?` character
Expand Down