Cluster discoverability improvement - include addresses of the replicas #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a slight change to consensus cluster formation.
Worker nodes can form a cluster in order to achieve consensus about an execution, when instructed to do so by the head node.
However, it might be the case that workers have never seen each other before, and don't know the addresses where they could reach their fellow workers.
Now, head node includes the multiaddresses of the peers chosen to form a consensus in the
FormClustermessage payload. Workers receiving this message will add these addresses to their address book, if they do not know of the peer already, That way when the consensus communication starts, they'll know how to reach their fellow replicas.