[Pool Simulator] Add validation in new form #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…multiple-types-of-amm
luizakp
requested review from
ribeirojose,
devjoaov,
yvesfracari and
mendesfabio
as code owners
BAL-527 Add validation in new Form
Requirements:
|
luizakp
had a problem deploying
to
bleu-balancer-tools-pr-171-preview
GitHub Actions
Failure
ribeirojose
reviewed
Jul 28, 2023
ribeirojose
reviewed
Jul 28, 2023
apps/balancer-tools/src/app/poolsimulator/(components)/ShareButton.tsx
Outdated
Show resolved
Hide resolved
ribeirojose
reviewed
Jul 28, 2023
apps/balancer-tools/src/app/poolsimulator/(components)/PoolParamsForm.tsx
Outdated
Show resolved
Hide resolved
yvesfracari
previously approved these changes
Jul 28, 2023
apps/balancer-tools/src/app/poolsimulator/(components)/PoolParamsForm.tsx
Show resolved
Hide resolved
apps/balancer-tools/src/app/poolsimulator/(components)/PoolParamsForm.tsx
Outdated
Show resolved
Hide resolved
apps/balancer-tools/src/app/poolsimulator/(components)/ShareButton.tsx
Outdated
Show resolved
Hide resolved
* Remove AMM convertions * Add tokens on Pool Params form * show tokens on analysis page * solve luiza comments --------- Co-authored-by: luizakp <[email protected]>
yvesfracari
had a problem deploying
to
bleu-balancer-tools-pr-171-preview
GitHub Actions
Failure
yvesfracari
had a problem deploying
to
bleu-balancer-tools-pr-171-preview
GitHub Actions
Failure
luizakp
temporarily deployed
to
bleu-balancer-tools-pr-171-preview
GitHub Actions
Inactive
ribeirojose
reviewed
Jul 28, 2023
| @@ -169,6 +182,18 @@ export function PoolParamsForm() { | |||
| </span> | |||
| </div> | |||
| ))} | |||
| <div className="flex flex-col"> | |||
| <label className="mb-2 block text-sm text-slate12">Tokens</label> | |||
| {errors?.tokens?.message && ( | |||
There was a problem hiding this comment.
👍 good strategy. think this was not in the video though, was it?
There was a problem hiding this comment.
No, this is from PYC's PR
ribeirojose
reviewed
Jul 28, 2023
apps/balancer-tools/src/app/poolsimulator/(components)/TokenTable.tsx
Outdated
Show resolved
Hide resolved
luizakp
had a problem deploying
to
bleu-balancer-tools-pr-171-preview
GitHub Actions
Error
luizakp
had a problem deploying
to
bleu-balancer-tools-pr-171-preview
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Next Step7.43.9and @hookform/resolvers to3.1.0due to unexpected form behaviorNext Stepit was expected to show the data that the user defined on the forms. But when importing a pool and changing those parameters the data displayed was the imported. E.g. Import a pool with swap fee of 0.001 and changed this value to 9. The expected value on pool Params visualization is 9, but rendered value was 0.001.https://www.loom.com/share/b0a63d9f67234169b307f7f7b325d692?sid=ad4e37f3-70ff-49f3-aa76-118377744a51
Commits regarding this PR: