Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Pool Simulator] Implement form second step #172

Merged
merged 34 commits into from
Aug 2, 2023
Merged

[Pool Simulator] Implement form second step #172

merged 34 commits into from
Aug 2, 2023

Conversation

yvesfracari
Copy link
Contributor

@yvesfracari yvesfracari commented Jul 28, 2023 •
edited by ribeirojose
Loading

yvesfracari and others added 24 commits July 21, 2023 16:56
@yvesfracari
chore: add generic form template
6a5ad3c
@yvesfracari
wip: add validation place holder
e9b3b72
@luizakp
Merge branch 'main' into pedro/bal-500-add-forms-interface-to-accept-…
342621e 
…multiple-types-of-amm
@luizakp
chore: useStableSwap for usePoolSimulator
e7979f3
@luizakp
feat: add gyro E to search pool
5583323
@luizakp
chore: add dialog when changing the pool type
f57d4e7
@luizakp
fix: invoking usePoolSimulator context on analysis page
9269786
@luizakp
remove: delete commented files
367be0a
@luizakp
refactor: dialog when changing the pool type
083f1b0
@luizakp
merge from main
3d11895
@luizakp
chore? reset pool params form after changing pool type
9ab8eaf
@luizakp
fix: sidebar max height
d0862b8
@luizakp
fix: move convertAnalysisData to utils folder
009b327
@luizakp
chore? display pool params on analysis page
63e42be
@luizakp
chore: move pool simulator types to a single file
6c00db3
@luizakp
fix: pooltypeEnum import
b146409
@luizakp
fix: GyroE schema
db8ff2a
@luizakp
fix: bug - replace form data with initialData onSubmit
153b323
@luizakp
fix: import TokensData
3903c84
@luizakp
merge from main
ec74b97
@yvesfracari @luizakp
[Pool Simulator] Add tokens table on Pool Params Form pt.1 (#170)
e010189 
* Remove AMM convertions

* Add tokens on Pool Params form

* show tokens on analysis page

* solve luiza comments

---------

Co-authored-by: luizakp <[email protected]>
@yvesfracari
update balancer-sor version
a309eec
@yvesfracari
fix: imports at math-poolsimulator package
ed7414b
@yvesfracari
wip: add second step of menu with tabs
79a35eb
@linear
Copy link

linear bot commented Jul 28, 2023

BAL-499 Implement second step

Must:

  • Start the page with the first step data as reference.
  • User can't remove and add tokens. It can just edit token parameters (decimals, balances, rates, weights…).
  • User can load existing pool parameters (pool type, and parameters, not tokens).
  • Check errors (including tokens number) when submit;

If task get to big, we could break in sub tasks

@yvesfracari yvesfracari had a problem deploying to bleu-balancer-tools-pr-172-preview July 28, 2023 20:06 — with GitHub Actions Failure
@yvesfracari yvesfracari changed the base branch from main to luiza/bal-527-add-validation-in-new-form July 28, 2023 20:10
Base automatically changed from luiza/bal-527-add-validation-in-new-form to main July 31, 2023 12:55
ribeirojose
ribeirojose requested changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@ribeirojose ribeirojose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the right direction, but there's a couple sharp edges that need to be polished and I'm curious about . Don't think we should merge unless there's a very clear rationale behind that, since it's non standard, especially in a React-ive app.

@ribeirojose ribeirojose had a problem deploying to bleu-balancer-tools-pr-172-preview August 1, 2023 18:02 — with GitHub Actions Failure
@ribeirojose ribeirojose had a problem deploying to bleu-balancer-tools-pr-172-preview August 2, 2023 01:35 — with GitHub Actions Failure
@ribeirojose @yvesfracari
Refactor CustomEvents out (#174)
837e528 
* refactor Tabs component to allow for parent value/setter state

* remove customEvents from Menu

* add idea for how to leverage TabContext to trigger form actions

* add idea to use useEffect to substitute customEvent logic

* refactor pool simulator forms

---------

Co-authored-by: Pedro Yves Fracari <[email protected]>
@ribeirojose ribeirojose had a problem deploying to bleu-balancer-tools-pr-172-preview August 2, 2023 15:27 — with GitHub Actions Error
ribeirojose
ribeirojose previously approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@ribeirojose ribeirojose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we worked this morning on some refactors in #174. Looking sharp 🔪

@ribeirojose ribeirojose had a problem deploying to bleu-balancer-tools-pr-172-preview August 2, 2023 15:28 — with GitHub Actions Failure
@yvesfracari yvesfracari had a problem deploying to bleu-balancer-tools-pr-172-preview August 2, 2023 16:45 — with GitHub Actions Error
@yvesfracari yvesfracari had a problem deploying to bleu-balancer-tools-pr-172-preview August 2, 2023 16:47 — with GitHub Actions Error
@yvesfracari yvesfracari merged commit 1687f03 into main Aug 2, 2023
1 of 2 checks passed
@yvesfracari yvesfracari deleted the pedro/bal-499-implement-second-step branch August 2, 2023 16:48
@yvesfracari yvesfracari had a problem deploying to bleu-balancer-tools-pr-172-preview August 2, 2023 16:48 — with GitHub Actions Failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luizakp luizakp luizakp left review comments

@ribeirojose ribeirojose ribeirojose left review comments

@devjoaov devjoaov Awaiting requested review from devjoaov

@mendesfabio mendesfabio Awaiting requested review from mendesfabio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yvesfracari @ribeirojose @luizakp