Fix ts check and refactor token select #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ribeirojose
changed the base branch from
main
to
jose/cow-252-create-withdraw-flow
ribeirojose
reviewed
May 29, 2024
ribeirojose
reviewed
May 29, 2024
| <CommandInput /> | ||
| {/* @ts-ignore */} | ||
| <CommandList> | ||
| {/* @ts-ignore */} |
There was a problem hiding this comment.
what was it complaining about?
There was a problem hiding this comment.
the interface, it doesn't expect a child, to solve this we have to solve the errors on command file.
ribeirojose
reviewed
May 29, 2024
apps/cow-amm-deployer/src/app/new/(components)/TokenAmountInput.tsx
Outdated
Show resolved
Hide resolved
…eate-withdraw-flow-fix-ts-errors
ribeirojose
force-pushed
the
jose/cow-252-create-withdraw-flow-fix-ts-errors
branch
from
3a75064
to
a7f4dc0
Compare
yvesfracari
merged commit 465c7a7
into
jose/cow-252-create-withdraw-flow
6 of 9 checks passed
yvesfracari
added a commit
that referenced
this pull request
May 29, 2024
* deploy AMM using ConstantProductFactory * move standalone cow-amm code from composble-cow-api repo * run formatting * remove ts-retry * add initial version of standalone amm page * fix lint issues * add format command * remove commented code * add insuficient token balance error * refactor: use standalone amm types * wip: refactor amm manager page * rename bleu-fi to bleu everywhere * add gql.tada and graphql-request to make queries * fix ts errors in homewrapper * fix ts issues * run formatting * refactor data fetching * update deps * Create Withdraw page (#687) * Refactor interface of token info and token logo components * Add withdraw relevant data to ICoWAMM * Add withdraw page * Remove unecessary imagesSrc states on token logo component * use react cache * remove vercel actions * use owner on cow explorer link (#688) Co-authored-by: José Ribeiro <[email protected]> * add turbo to project * update voting gauges * fix prettier * disallow parallel ci runs for the same branch * fix: fix contracts test workflow file * fix import * Fix ts check and refactor token select (#689) * delete tx processing pages * delegte use running amm info hook * no check command ui ts errors * Use cow token list on token select * Fix token amount input now showing balance if 0 * fix formatting * avoid using localstorage if window is undefined * fix ts errors * ignore zod ts errors --------- Co-authored-by: José Ribeiro <[email protected]> Co-authored-by: José Ribeiro <[email protected]> --------- Co-authored-by: Pedro Yves Fracari <[email protected]> Co-authored-by: Pedro Yves Fracari <[email protected]>
ribeirojose
added a commit
that referenced
this pull request
May 31, 2024
* deploy AMM using ConstantProductFactory * move standalone cow-amm code from composble-cow-api repo * run formatting * remove ts-retry * add initial version of standalone amm page * fix lint issues * add format command * remove commented code * add insuficient token balance error * refactor: use standalone amm types * wip: refactor amm manager page * rename bleu-fi to bleu everywhere * add gql.tada and graphql-request to make queries * fix ts errors in homewrapper * fix ts issues * run formatting * refactor data fetching * update deps * Create Withdraw page (#687) * Refactor interface of token info and token logo components * Add withdraw relevant data to ICoWAMM * Add withdraw page * Remove unecessary imagesSrc states on token logo component * use react cache * remove vercel actions * use owner on cow explorer link (#688) Co-authored-by: José Ribeiro <[email protected]> * add turbo to project * update voting gauges * fix prettier * disallow parallel ci runs for the same branch * fix: fix contracts test workflow file * fix import * Fix ts check and refactor token select (#689) * delete tx processing pages * delegte use running amm info hook * no check command ui ts errors * Use cow token list on token select * Fix token amount input now showing balance if 0 * fix formatting * avoid using localstorage if window is undefined * fix ts errors * ignore zod ts errors --------- Co-authored-by: José Ribeiro <[email protected]> Co-authored-by: José Ribeiro <[email protected]> * add disable and refactor edit transactions * refactor transactions args and add enable and disable action * run formating --------- Co-authored-by: José Ribeiro <[email protected]> Co-authored-by: José Ribeiro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The token selected new features are:
To fix the ts-errors, the TX processing pages and running amm hook were deleted (were not working anymore and this should be fixed later)