Pedro/cow 284 milestone review 2 #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ribeirojose
reviewed
Jun 18, 2024
Comment on lines
+23
to
+25
| value={{ | ||
| managedTransaction, | ||
| }} |
There was a problem hiding this comment.
any reason why encapsulate this in another object?
ribeirojose
reviewed
Jun 18, 2024
| }, [isPonderAPIUpToDate]); | ||
|
|
||
| useEffect(() => { | ||
| if (!["final", "confirmed", "error", "idle"].includes(status || "")) { |
There was a problem hiding this comment.
we should remove confirmed from this now right?
There was a problem hiding this comment.
We're using more the ponder update as a trigger, so I think that is ok to let this
ribeirojose
reviewed
Jun 18, 2024
| !["final", "idle", "confirmed", "error"].includes(status || "") | ||
| } | ||
| loadingText="Depositing..." | ||
| loading={isSubmitting || isAmmUpdating} |
There was a problem hiding this comment.
so are we ignoring the tx now 🤔 ?
There was a problem hiding this comment.
actually the isAmmUpdating is true when the status is something being processed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.