Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added support for Arc browser #36

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

viduranga
Copy link

Added support for Arc browser (only for macos). Since Arc doesn't allow invocation via terminal, used Arc's Apple Script interface. However this means user is not allowed to pass additional configs via AWS_VAULT_PL_BROWSER_LAUNCH_OPTS for Arc browser yet.

Tested locally on:
Version 1.53.0 (52080)
Chromium Engine Version 127.0.6533.73

@blimmer
Copy link
Owner

blimmer commented Jul 27, 2024

Hi @viduranga - thank you for this PR!

I just took a look at this code, and it doesn't quite do what the other avli commands do. For other browsers, we create a new profile for each aws-vault profile so multiple AWS consoles can be open in your preferred browser at once.

Arc, as with many other browsers, shares the session between all incognito windows. So, if you were to use avli profile-1, then avli profile-2, you'd run into an error with Arc. With all other supported browsers, we could have both profile-1 and profile-2 open at the same time. This wasn't super clear in the README before, so I merged #37 to make it more obvious what my intention with the avli command is.

I'm not an expert on Arc, but it looks like they have a concept of a profile as well: https://resources.arc.net/hc/en-us/articles/19227964556183-Profiles-Separate-Work-Personal-Browsing

It seems that profiles are more permanent on other browsers, so it might not be a good fit. However, I'd want the behavior with Arc to be the same as the other browsers we currently support.

Would you be willing to take a look and see if you could write AppleScript to support multiple avli aws-vault profiles in Arc?

@viduranga
Copy link
Author

Hi @blimmer,
Tested and I see the problem. Arc spaces and profiles seems to be not available to the incognito sessions. Let me have a crack at it and see if I can find a solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants