-
Notifications
You must be signed in to change notification settings - Fork 45
feat: Add daisy V3, support, text only #326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
@pauliyobo great work. Will test soon. |
|
@pauliyobo @mush42 I'm testing this great feature. While it works, the status quo has the following issues:
Thanks. |
|
@pauliyobo @mush42 Any progress on this? In particular, any chance of enabling heading navigation and access to the elements list? |
|
Hello, |
|
The_Theory_of_the_Leisure_Class.zip |
|
@amirsol81 |
@pauliyobo Thanks! Great job! Now heading navigation and Elements list, via Control+F7, work as expected. However, links in DAISY documents cannot be activated by pressing Control+Enter on them. Links are properly detected, but pressing Control+Enter on them does nothing. The provided DAISY book above also has many internal links to demonstrate the issue. |
|
So @pauliyobo can something be done for the remaining "links" issue? As I mentioned above, Bookworm cannot activate links in DAISY books via Control+Enter. |
|
@amirsol81 links should be functioning properly now. |
@pauliyobo Thanks! Very much appreciated. |
|
@pauliyobo It seems that the installers for this pull request are no longer available, or I can't find them. Would you please provide the download links at least for Windows 64-Bit? I want to test fixed links in DAISY books. |
|
Hello. |
|
@pauliyobo Thanks for your awesome efforts! I just grabbed it. |
|
@pauliyobo I downloaded the latest 64-Bit release based on your latest fix. However, on Windows 11 25H2 it can't normally. It should be run as Admin only to work, unlike previous builds. |
|
I suspect that NSIS is causing the problem, which is not present in my local build. Another problem is that the Portable version does not start. |
|
@cary-rowen Thanks - much appreciated. Also the app's start-up time is overly long even on powerful machines. Any chance of reducing it? |
|
@amirsol81 |
|
@cary-rowen Thanks! This build fixes the issue. |
|
@amirsol81 |
|
@pauliyobo Thanks, but the table of contents section of the book contains valid internal links to the beginning of chapters, and both the Kurzweil 1000 and QRead can detect and activate them. |
|
@pauliyobo Please take a look at the second free-domain Bookshare DAISY book I'm providing here. The Contents section has |
|
@amirsol81 |
|
pauliyobo Thanks! Can we grab the try builds now?Message ID:
***@***.***>
|
|
@pauliyobo Thanks! Can we download the try builds now?Message ID:
***@***.***>
|
|
Hello @pauliyobo
Should we just support Daisy and drop zip? I don't know much about this, do you have any further thoughts? |
|
@cary-rowen honestly I have no idea either. |
|
Yes, I think a well-defined Daisy format makes more sense than a general zip archive format. |
|
@cary-rowen Thanks. I grabbed it. |
This PR aims to introduce daisy support into bookworm.
Currently, the daisy format targeted is daisy 3.
Since adding media support isn't trivial in our case, only text books will be supported.
While the PR is being finalized, artifacts derived from this branch will have documents with the .zip extension temporarily disabled since daisy books often use the same extension, and a builtin mechanism to distinguish them hasn't been added yet.
@mush42 @cary-rowen this might be interesting for you.
fixes #309
fixes #122