Skip to content

Conversation

@pauliyobo
Copy link
Collaborator

Link to issue number:

closes #346

Summary of the issue:

Users were unable to open certain wikipedia pages from bookworm.

Description of how this pull request fixes the issue:

Wikimedia sites require a HTTP User-Agent header for all requests.
We did not set User-Agents in our request, and this PR fixes the issue by introducing one.
For context, see: https://foundation.wikimedia.org/wiki/Policy:Wikimedia_Foundation_User-Agent_Policy

Testing performed:

Manual

Known issues with pull request:

None

@pauliyobo
Copy link
Collaborator Author

Hello.
@cary-rowen
The first link seems to work.
The second link fails with a 403 error, but I am not familiar with that site, so I can't tell if it's because of an invalid User-Agent or because of another reason. If you have more insight, that'd be helpful.
The third link had an issue unrelated to this PR, which I have already integrated from the develop branch.

@pauliyobo
Copy link
Collaborator Author

pauliyobo commented Nov 5, 2025

Hello. Since the original issue is resolved, I'll go ahead and merge this.

@pauliyobo pauliyobo merged commit e064155 into develop Nov 5, 2025
10 of 12 checks passed
@pauliyobo pauliyobo deleted the issue346 branch November 5, 2025 17:56
@amirsol81
Copy link

@pauliyobo @cary-rowen Where or how can I fetch the latest build based on this fix?

@cary-rowen
Copy link
Collaborator

Please note that you can always find successfully built artifacts on the ActionWorkflow page.

@amirsol81
Copy link

@cary-rowen But at least in this particular instance, builds aren't available. And working with the workflow pages isn't the easiest task at hand.

@cary-rowen
Copy link
Collaborator

@amirsol81
Copy link

@cary-rowen Thanks.

@cary-rowen
Copy link
Collaborator

By the way, I don't think you need to download every single build commit. I hope we can provide some more stable dev versions for testing after a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The Open URL feature fails with Wikipedia pages

4 participants