fix: add nil handling for BabbageTransactionOutput Utxorpc() #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agaffney
reviewed
Jul 11, 2024
ledger/babbage_test.go
Outdated
| DatumHash []byte | ||
| } | ||
|
|
||
| func TestUtxorpc_DatumOptionNil(t *testing.T) { |
There was a problem hiding this comment.
We should keep the test names prefixed with the object type, since all tests under ledger/ are in the same namespace. This should be something like TestBabbageTransactionOutput_Utxorpc_DatumOptionNil
ledger/babbage_test.go
Outdated
| assert.Equal(t, uint64(1000), txOutput.Coin) | ||
| } | ||
|
|
||
| func TestDatumHashReturnsNil(t *testing.T) { |
…ude unit tests Signed-off-by: Ales Verbic <[email protected]>
verbotenj
force-pushed
the
feat/add-test-babbage-utxrpc
branch
from
b64f93f
to
1e255e7
Compare
agaffney
approved these changes
Jul 11, 2024
This was referenced Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
include unit tests