generated from TBD54566975/tbd-project-template
-
Notifications
You must be signed in to change notification settings - Fork 9
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
revert: "chore: remove "ftl schema generate"" (#3929)
Reverts #3921 --------- Co-authored-by: Juho Makinen <[email protected]>
- Loading branch information
1 parent
23878bf
commit bb68bd8
Showing
4 changed files
with
203 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,8 @@ | ||
package main | ||
|
||
type schemaCmd struct { | ||
Get getSchemaCmd `default:"" cmd:"" help:"Retrieve the cluster FTL schema."` | ||
Diff schemaDiffCmd `cmd:"" help:"Print any schema differences between this cluster and another cluster. Returns an exit code of 1 if there are differences."` | ||
Import schemaImportCmd `cmd:"" help:"Import messages to the FTL schema."` | ||
Get getSchemaCmd `default:"" cmd:"" help:"Retrieve the cluster FTL schema."` | ||
Diff schemaDiffCmd `cmd:"" help:"Print any schema differences between this cluster and another cluster. Returns an exit code of 1 if there are differences."` | ||
Generate schemaGenerateCmd `cmd:"" help:"Stream the schema from the cluster and generate files from the template."` | ||
Import schemaImportCmd `cmd:"" help:"Import messages to the FTL schema."` | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,186 @@ | ||
package main | ||
|
||
import ( | ||
"context" | ||
"fmt" | ||
"os" | ||
"path/filepath" | ||
"strings" | ||
"time" | ||
|
||
"connectrpc.com/connect" | ||
"github.com/block/scaffolder" | ||
"github.com/block/scaffolder/extensions/javascript" | ||
"github.com/radovskyb/watcher" | ||
"golang.org/x/exp/maps" | ||
"golang.org/x/sync/errgroup" | ||
|
||
ftlv1 "github.com/block/ftl/backend/protos/xyz/block/ftl/v1" | ||
"github.com/block/ftl/backend/protos/xyz/block/ftl/v1/ftlv1connect" | ||
"github.com/block/ftl/common/schema" | ||
"github.com/block/ftl/common/slices" | ||
"github.com/block/ftl/internal/log" | ||
) | ||
|
||
type schemaGenerateCmd struct { | ||
Watch time.Duration `short:"w" help:"Watch template directory at this frequency and regenerate on change."` | ||
Template string `arg:"" help:"Template directory to use." type:"existingdir"` | ||
Dest string `arg:"" help:"Destination directory to write files to (will be erased)."` | ||
ReconnectDelay time.Duration `help:"Delay before attempting to reconnect to FTL." default:"5s"` | ||
} | ||
|
||
func (s *schemaGenerateCmd) Run(ctx context.Context, client ftlv1connect.SchemaServiceClient) error { | ||
if s.Watch == 0 { | ||
return s.oneOffGenerate(ctx, client) | ||
} | ||
return s.hotReload(ctx, client) | ||
} | ||
|
||
func (s *schemaGenerateCmd) oneOffGenerate(ctx context.Context, schemaClient ftlv1connect.SchemaServiceClient) error { | ||
response, err := schemaClient.GetSchema(ctx, connect.NewRequest(&ftlv1.GetSchemaRequest{})) | ||
if err != nil { | ||
return fmt.Errorf("failed to get schema: %w", err) | ||
} | ||
modules, err := slices.MapErr(response.Msg.Schema.Modules, schema.ModuleFromProto) | ||
if err != nil { | ||
return fmt.Errorf("invalid module schema: %w", err) | ||
} | ||
return s.regenerateModules(log.FromContext(ctx), modules) | ||
} | ||
|
||
func (s *schemaGenerateCmd) hotReload(ctx context.Context, client ftlv1connect.SchemaServiceClient) error { | ||
watch := watcher.New() | ||
defer watch.Close() | ||
|
||
absTemplatePath, err := filepath.Abs(s.Template) | ||
if err != nil { | ||
return fmt.Errorf("failed to get absolute path for template: %w", err) | ||
} | ||
absDestPath, err := filepath.Abs(s.Dest) | ||
if err != nil { | ||
return fmt.Errorf("failed to get absolute path for destination: %w", err) | ||
} | ||
|
||
if strings.HasPrefix(absDestPath, absTemplatePath) { | ||
return fmt.Errorf("destination directory %s must not be inside the template directory %s", absDestPath, absTemplatePath) | ||
} | ||
|
||
logger := log.FromContext(ctx) | ||
logger.Debugf("Watching %s", s.Template) | ||
|
||
if err := watch.AddRecursive(s.Template); err != nil { | ||
return fmt.Errorf("failed to watch template directory: %w", err) | ||
} | ||
|
||
wg, ctx := errgroup.WithContext(ctx) | ||
|
||
moduleChange := make(chan []*schema.Module) | ||
|
||
wg.Go(func() error { | ||
for { | ||
stream, err := client.PullSchema(ctx, connect.NewRequest(&ftlv1.PullSchemaRequest{})) | ||
if err != nil { | ||
return fmt.Errorf("failed to pull schema: %w", err) | ||
} | ||
|
||
modules := map[string]*schema.Module{} | ||
regenerate := false | ||
for stream.Receive() { | ||
msg := stream.Msg() | ||
switch msg.ChangeType { | ||
case ftlv1.DeploymentChangeType_DEPLOYMENT_CHANGE_TYPE_ADDED, ftlv1.DeploymentChangeType_DEPLOYMENT_CHANGE_TYPE_CHANGED: | ||
if msg.Schema == nil { | ||
return fmt.Errorf("schema is nil for added/changed deployment %q", msg.GetDeploymentKey()) | ||
} | ||
module, err := schema.ModuleFromProto(msg.Schema) | ||
if err != nil { | ||
return fmt.Errorf("failed to convert proto to module: %w", err) | ||
} | ||
modules[module.Name] = module | ||
|
||
case ftlv1.DeploymentChangeType_DEPLOYMENT_CHANGE_TYPE_REMOVED: | ||
if msg.Schema == nil { | ||
return fmt.Errorf("schema is nil for removed deployment %q", msg.GetDeploymentKey()) | ||
} | ||
if msg.ModuleRemoved { | ||
delete(modules, msg.Schema.Name) | ||
} | ||
default: | ||
} | ||
if !msg.More { | ||
regenerate = true | ||
} | ||
if !regenerate { | ||
continue | ||
} | ||
|
||
moduleChange <- maps.Values(modules) | ||
} | ||
|
||
stream.Close() | ||
logger.Debugf("Stream disconnected, attempting to reconnect...") | ||
time.Sleep(s.ReconnectDelay) | ||
} | ||
}) | ||
|
||
wg.Go(func() error { return watch.Start(s.Watch) }) | ||
|
||
var previousModules []*schema.Module | ||
for { | ||
select { | ||
case <-ctx.Done(): | ||
return fmt.Errorf("context cancelled: %w", wg.Wait()) | ||
|
||
case event := <-watch.Event: | ||
logger.Debugf("Template changed (%s), regenerating modules", event.Path) | ||
if err := s.regenerateModules(logger, previousModules); err != nil { | ||
return fmt.Errorf("failed to regenerate modules: %w", err) | ||
} | ||
|
||
case modules := <-moduleChange: | ||
previousModules = modules | ||
if err := s.regenerateModules(logger, modules); err != nil { | ||
return fmt.Errorf("failed to regenerate modules: %w", err) | ||
} | ||
} | ||
} | ||
} | ||
|
||
func (s *schemaGenerateCmd) regenerateModules(logger *log.Logger, modules []*schema.Module) error { | ||
if err := os.RemoveAll(s.Dest); err != nil { | ||
return fmt.Errorf("failed to remove destination directory: %w", err) | ||
} | ||
|
||
for _, module := range modules { | ||
if err := scaffolder.Scaffold(s.Template, s.Dest, module, | ||
scaffolder.Extend(javascript.Extension("template.js", javascript.WithLogger(makeJSLoggerAdapter(logger)))), | ||
); err != nil { | ||
return fmt.Errorf("failed to scaffold module %s: %w", module.Name, err) | ||
} | ||
} | ||
logger.Debugf("Generated %d modules in %s", len(modules), s.Dest) | ||
return nil | ||
} | ||
|
||
func makeJSLoggerAdapter(logger *log.Logger) func(args ...any) { | ||
return func(args ...any) { | ||
strs := slices.Map(args, func(v any) string { return fmt.Sprintf("%v", v) }) | ||
level := log.Debug | ||
if prefix, ok := args[0].(string); ok { | ||
switch prefix { | ||
case "log:": | ||
level = log.Info | ||
case "debug:": | ||
level = log.Debug | ||
case "error:": | ||
level = log.Error | ||
case "warn:": | ||
level = log.Warn | ||
} | ||
} | ||
logger.Log(log.Entry{ | ||
Level: level, | ||
Message: strings.Join(strs[1:], " "), | ||
}) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.