fix: fail on 2nd failed attempt of error deserialization #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to #42. Follow up to #93. I realized that we potentially have an infinite loop (although each iteration slept for 1 s). If a user broke the deployment so that `testgen-hs` became inaccessible, the request to deserialize a CBOR would never be fulfilled, not even with an error. We only returned deserialization errors from a working Haskell tool itself. Lower-level errors were only logged to our `stdout`. After this change, a "repeated internal failure" is returned after the *2nd* attempt to deserialize the same request fails on a lower level (e.g. because the child binary cannot be found, because someone moved it).
Deploying blockfrost-platform with
|
| Latest commit: |
1309488
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7d6ceea2.blockfrost-platform.pages.dev |
| Branch Preview URL: | https://fix-fail-deser-on-retry.blockfrost-platform.pages.dev |
gytis-ivaskevicius
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #42.
Follow up to #93.
Context
I realized that we potentially have an infinite loop (although each iteration slept for 1 s). If a user broke the deployment so that
testgen-hsbecame inaccessible, the request to deserialize a CBOR would never be fulfilled, not even with an error. We only returned deserialization errors from a working Haskell tool itself. Lower-level errors were only logged to ourstdout.After this change, a "repeated internal failure" is returned after the 2nd attempt to deserialize the same request fails on a lower level (e.g. because the child binary cannot be found, because someone moved it).
I recommend reviewing with hidden whitespace, its much clearer then.
Important Changes Introduced
None to the happy path.
Failure mode is better.