Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve message validation #175

Merged
merged 4 commits into from
Nov 27, 2024
Merged

Improve message validation #175

merged 4 commits into from
Nov 27, 2024

Conversation

Maelkum
Copy link
Collaborator

@Maelkum Maelkum commented Nov 14, 2024

  • better message validation
  • clearer API responses/status code
  • checking if message is valid for a given node type is done in a single place => message processing functions can be cleaner

@Maelkum Maelkum requested a review from dmikey November 14, 2024 20:00
@Maelkum Maelkum self-assigned this Nov 14, 2024
Copy link
Contributor

@dmikey dmikey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean, very easy to read over now!

@dmikey dmikey merged commit 1f86fc1 into main Nov 27, 2024
5 checks passed
@dmikey dmikey deleted the improve-validation branch November 27, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants