Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

experiment: reduce number of source endpoints to 1 #386

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

ckamm
Copy link
Contributor

@ckamm ckamm commented Apr 3, 2024

Prediction is that this has no negative effect but reduces memory use a lot.

Prediction is that this has no negative effect but reduces memory use a
lot.
@ckamm ckamm requested a review from godmodegalactus April 3, 2024 15:25
@ckamm ckamm force-pushed the ckamm/rotating-queue-experiment branch from 868cba4 to b9e470b Compare April 3, 2024 15:29
) -> Self {
let number_of_clients = fanout * 4;
let number_of_clients = 1; // fanout * 4;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we make it as an argument later then ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I want to see if it works first - and if it does, we can drop the RotatingQueue entirely

@ckamm ckamm merged commit 0681037 into main Apr 3, 2024
3 checks passed
godmodegalactus pushed a commit that referenced this pull request Apr 3, 2024
Prediction is that this has no negative effect but reduces memory use a
lot.
@ckamm ckamm deleted the ckamm/rotating-queue-experiment branch April 4, 2024 12:13
Lou-Kamades pushed a commit that referenced this pull request Apr 16, 2024
Prediction is that this has no negative effect but reduces memory use a
lot.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants