Handle updated VMware refresh log timings #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the ems_refresher_mixin to support a pattern for targeted refresh. This was largely taken from the VMWare targeted refresh process. The major difference with the targeted refresh approach is that refreshers should collect inventory from the provider separate from parsing that inventory. In many more recent refreshers, the inventory is collected as it's being parsed. The problem this poses with targeted refresh is that it doesn't allow the refresher to filter the data down to the specific targets that should be refreshed. This implementation allows "legacy" refreshers (those that don't yet support targeted refresh) to continue to collect inventory while parsing it. However, as providers implement targeted refresh, they should adopt the process of separately collecting inventory. The other major change with this implementation is that now the VMWare refresher uses the same ems_refersher_mixin that all other refreshers use. This helps to solidify the ability for the mixin to handle both non-targeted and targeted refreshes. The major caveat to this approach is that the logging from the old VMWare refresher is slightly different from the ems_refresher_mixin. If log analysis tools exist that rely on the old logging, they will need to be updated to examine the new logging labels (see updated Benchmark calls in this commit for details).
Support both older VMware refresh logging as well as the newer generic refresh mixin
blomquisg
force-pushed
the
targeted_refresh_mixin
branch
2 times, most recently
from
7122713 to
4050485
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support both older VMware refresh logging as well as the newer generic refresh mixin in the ems_refefresh log parsing tool.
cc @blomquisg