Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set studio + sro to zero bedrooms #4611

Merged
merged 3 commits into from
Jan 27, 2025
Merged

Conversation

ColinBuyck
Copy link
Collaborator

@ColinBuyck ColinBuyck commented Jan 24, 2025

This PR addresses metrotranscom#1059 and https://app.zenhub.com/workspaces/bloom-5dc32d7144bd400001315dac/issues/gh/bloom-housing/bloom/4220

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

This PR saves Studios and SROs to have zero bedrooms rather than null bedrooms. This doesn't change much in core but it is critical for filtering in doorway which is a feature core will likely get soon.

After merge, I will be running the following query in Core, HBA, and Doorway since querying existing data showed that all null bedroom units were Studios or SROs
Update units set num_bedrooms=0 where num_bedrooms is null;

How Can This Be Tested/Reviewed?

This can be tested by creating SROs and Studios on the partner side and then checking the units table to ensure they are saved as zero rather than null number of bedrooms.

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

Copy link

netlify bot commented Jan 24, 2025

Deploy Preview for partners-bloom-dev ready!

Name Link
🔨 Latest commit 04f1244
🔍 Latest deploy log https://app.netlify.com/sites/partners-bloom-dev/deploys/6797ba77fae513000887864a
😎 Deploy Preview https://deploy-preview-4611--partners-bloom-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 24, 2025

Deploy Preview for bloom-exygy-dev ready!

Name Link
🔨 Latest commit 04f1244
🔍 Latest deploy log https://app.netlify.com/sites/bloom-exygy-dev/deploys/6797ba77def811000873af42
😎 Deploy Preview https://deploy-preview-4611--bloom-exygy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ColinBuyck ColinBuyck marked this pull request as ready for review January 24, 2025 22:29
@ColinBuyck ColinBuyck added the 1 review needed Requires 1 more review before ready to merge label Jan 24, 2025
Copy link
Collaborator

@ludtkemorgan ludtkemorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected!

sites/partners/src/lib/listings/UnitsFormatter.ts Outdated Show resolved Hide resolved
@ludtkemorgan ludtkemorgan added the ready to merge Should be applied when a PR has been reviewed and approved label Jan 24, 2025
@ColinBuyck ColinBuyck removed the 1 review needed Requires 1 more review before ready to merge label Jan 25, 2025
@ColinBuyck ColinBuyck merged commit 92dc357 into main Jan 27, 2025
20 checks passed
@ColinBuyck ColinBuyck deleted the 1059/studio-null-bedrooms branch January 27, 2025 17:13
ColinBuyck added a commit to metrotranscom/doorway that referenced this pull request Jan 27, 2025
* fix: set studio + sro to zero bedrooms

* fix: default approach
ColinBuyck added a commit to housingbayarea/bloom that referenced this pull request Jan 27, 2025
* fix: set studio + sro to zero bedrooms

* fix: default approach
ColinBuyck added a commit to metrotranscom/doorway that referenced this pull request Jan 27, 2025
ColinBuyck added a commit to housingbayarea/bloom that referenced this pull request Jan 28, 2025
* fix: set studio + sro to zero bedrooms

* fix: default approach
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Should be applied when a PR has been reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants