-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: set studio + sro to zero bedrooms #4611
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for partners-bloom-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for bloom-exygy-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ColinBuyck
added
the
1 review needed
Requires 1 more review before ready to merge
label
Jan 24, 2025
ludtkemorgan
approved these changes
Jan 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected!
ludtkemorgan
added
the
ready to merge
Should be applied when a PR has been reviewed and approved
label
Jan 24, 2025
ColinBuyck
removed
the
1 review needed
Requires 1 more review before ready to merge
label
Jan 25, 2025
ColinBuyck
added a commit
to metrotranscom/doorway
that referenced
this pull request
Jan 27, 2025
* fix: set studio + sro to zero bedrooms * fix: default approach
ColinBuyck
added a commit
to housingbayarea/bloom
that referenced
this pull request
Jan 27, 2025
* fix: set studio + sro to zero bedrooms * fix: default approach
ColinBuyck
added a commit
to metrotranscom/doorway
that referenced
this pull request
Jan 27, 2025
ColinBuyck
added a commit
to housingbayarea/bloom
that referenced
this pull request
Jan 28, 2025
* fix: set studio + sro to zero bedrooms * fix: default approach
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses metrotranscom#1059 and https://app.zenhub.com/workspaces/bloom-5dc32d7144bd400001315dac/issues/gh/bloom-housing/bloom/4220
Description
This PR saves Studios and SROs to have zero bedrooms rather than null bedrooms. This doesn't change much in core but it is critical for filtering in doorway which is a feature core will likely get soon.
After merge, I will be running the following query in Core, HBA, and Doorway since querying existing data showed that all null bedroom units were Studios or SROs
Update units set num_bedrooms=0 where num_bedrooms is null;
How Can This Be Tested/Reviewed?
This can be tested by creating SROs and Studios on the partner side and then checking the units table to ensure they are saved as zero rather than null number of bedrooms.
Author Checklist:
yarn generate:client
and/or created a migration when requiredReview Process: