Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for release of 1.0.1 #7

Merged
merged 2 commits into from
Jan 4, 2024
Merged

Conversation

sarahmonod
Copy link
Contributor

@sarahmonod sarahmonod commented Aug 21, 2023

This would be the first version to support 3.12

@mariocj89 it looks like we have no PyPI automation, do you want to publish this version manually? Or should we take the opportunity to add PyPI publishing to the Github Actions?

This would be the first version to support 3.12

Signed-off-by: Gus Monod <[email protected]>
@mariocj89
Copy link
Contributor

If you have the energy to automate it, it would be great!!

@godlygeek
Copy link
Contributor

@mariocj89 Would you mind making me and @pablogsal maintainers on the PyPI project?

I can't automate what I can't publish manually 😆

@godlygeek godlygeek force-pushed the release-1.0.1 branch 2 times, most recently from d6415a6 to 50e749c Compare December 19, 2023 00:32
Build sdists and wheels in CI, install wheels, and run the tests from
the installed wheels.

Signed-off-by: Matt Wozniski <[email protected]>
@godlygeek
Copy link
Contributor

@mariocj89 Would you mind making me and @pablogsal maintainers on the PyPI project?

You seem to have made Pablo a maintainer on https://pypi.org/project/pytest-pystack/ but I'm still not...

@pablogsal Can you pick this up if you have some time? I think what I've got here should work, except that the upload_pypi stage has never been tested, because I can't set up a token (I'm an admin on this repo, but not a maintainer on pypi.org).

@godlygeek
Copy link
Contributor

At the very least, the build_dists stage is succeeding, and the dists artifact contains a .whl and an sdist that should be good to publish to PyPI.

@godlygeek
Copy link
Contributor

You seem to have made Pablo a maintainer on https://pypi.org/project/pytest-pystack/ but I'm still not...

Hah, Pablo pointed out that that's because I needed to accept the invitation, and I never did, so it expired. Whoops! He reinvited me, so that's sorted now.

Copy link
Contributor

@godlygeek godlygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@godlygeek godlygeek merged commit 77e9a06 into bloomberg:main Jan 4, 2024
8 checks passed
@godlygeek
Copy link
Contributor

Success:

image

That's released, and now we have release automation.

@sarahmonod sarahmonod deleted the release-1.0.1 branch January 8, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants