Searchbox #2
Merged
Searchbox #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks straight forward, which means good! |
vkovrigo
reviewed
Jul 18, 2024
|
LGTM |
This hook is a companion to the SearchBox component. It allows for consumers to build their searchbox component from scratch instead of using the out of the box SearchBox component.
- Add error and loading state to SearchContext to manage search status and error handling - Update SearchBox to include InputHTMLAttributes for better flexibility in input handling - Adjust useSearchBox hook to set error and loading states in SearchContext - Restructure imports for better readability in search.context.tsx - Reorder and adjust SearchBoxProps to move debounceDelay configuration - Export necessary hooks and context from the search index file for unified module access
|
🎉 This issue has been resolved in version 0.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the searchbox component, hook and context