Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Vitest configuration has 2 errors:
By using the legacy configuration of Eslint, the rules need to be prepended with
@vitest/
instead ofvitest
. This wasn't in the docs, and if not using the appropriate prefix, it gives an error of missing definition of rule. (I created an issue in their repo to improve the docs about this [docs] Legacy rules are prepended with "@", but it is not in the docs vitest-dev/eslint-plugin-vitest#566)The config was disabling some rules that did not belong to the
vitest
plugin, but were frombloq/node
. Commonly, withmocha
, we would usebloq/node
beforebloq/mocha
, which causes those rules to be available. We tried to replicate that here, but as I am usingesm
, we can't use some of the rules frombloq/node
. By not including it, these rules are not defined, throwing an error as well. The correct behavior should be that every package should only disable rules from the config it extends. That's why I am removing from thevitest
config the following disabling of rules:As the vitest config did not work, I consider this a bug fix instead of a breaking change.