Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Debridge #97

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Add Debridge #97

wants to merge 8 commits into from

Conversation

bussyjd
Copy link

@bussyjd bussyjd commented Jan 23, 2025

No description provided.

@bussyjd bussyjd marked this pull request as ready for review February 11, 2025 09:50
@ef95023
Copy link
Collaborator

ef95023 commented Feb 19, 2025

hello friend,

we appreciate the work you've put into the debridge implementation, but we have a few concerns with the current approach

the code is tightly coupled to solana, requiring a solana connection and wallet for all bridge operations, even though debridge supports bridging between many different chains in any direction (e.g. evm to evm, evm to solana, solana to evm)

would you be open to refactoring this implementation to be more chain agnostic?

thanks again and your contribution is valued

@ayoubed
Copy link
Collaborator

ayoubed commented Feb 19, 2025

@bussyjd would love your feedback buddy :)

@bussyjd
Copy link
Author

bussyjd commented Feb 20, 2025

Hi there,
Agreed! Let me see what I can do

@rux-eth
Copy link
Collaborator

rux-eth commented Feb 21, 2025

adding to todos, closing for now

@rux-eth rux-eth closed this Feb 21, 2025
@rux-eth rux-eth reopened this Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants