Fix other clippy warnings

colmeia-bins/src/bin/colmeia-hyperswarm-dht.rs

@@ -28,6 +28,7 @@ fn main() {
         .unwrap_or_else(|| "10".into())
         .parse::<u64>()
         .expect("Could not parse duration into a number");
+    let duration = Duration::from_secs(duration);
 
     env_logger::init();
 
@@ -48,7 +49,7 @@ fn main() {
             .await
             .expect("could not start announcer");
 
-        let mut locator = Locator::listen(&config, duration)
+        let mut locator = Locator::listen(&config, Duration::from_secs(1))
             .await
             .expect("Could not start locator");
 

colmeia-bins/src/bin/colmeia-url-meta.rs

@@ -20,7 +20,7 @@ fn main() {
     }
 }
 
-fn invalid_public_key(e: HashParserError) -> () {
+fn invalid_public_key(e: HashParserError) {
     match e {
         HashParserError::InvalidHexHash(_) => {
             eprintln!("Invalid hyper url");

colmeia-hypercore/src/network.rs

@@ -53,7 +53,7 @@ where
             nodes: message
                 .nodes
                 .iter()
-                .map(|node| hypercore::Node::new(node.index, node.hash.to_vec(), node.size))
+                .map(|node| hypercore::Node::new(node.index, node.hash.clone(), node.size))
                 .collect(),
             signature: message
                 .signature
@@ -88,6 +88,7 @@ where
                 // self.remoteLength = self.remoteBitfield.last() + 1;
             }
         } else {
+            #[allow(clippy::cast_possible_truncation)]
             let mut start = message.start as usize;
             let len = message.length.unwrap_or(1);
             for _ in 0..len {
@@ -108,7 +109,7 @@ where
         for index in 0..=message.start {
             let request = proto::schema::Request {
                 index,
-                ..Default::default()
+                ..proto::schema::Request::default()
             };
             self.channel.request(request).await?;
         }
@@ -129,10 +130,11 @@ where
             // where this is contained in
             let have = proto::schema::Have {
                 start: feed_length as u64,
-                ..Default::default()
+                ..proto::schema::Have::default()
             };
             self.channel.have(have).await?;
         }
+        #[allow(clippy::cast_possible_truncation)]
         let rle = self
             .feed
             .read()
@@ -149,6 +151,9 @@ where
         Ok(())
     }
 
+    /// # Errors
+    ///
+    /// Returns the error if any of the protocol operations fail
     pub async fn replicate(
         &mut self,
         mut rx: impl futures::Sink<Emit> + Unpin + Send + 'static,

colmeia-hyperdrive/src/schema.rs

@@ -6,7 +6,7 @@
 #![allow(clippy::all)]
 
 #![allow(unused_attributes)]
-#![rustfmt::skip]
+#![cfg_attr(rustfmt, rustfmt_skip)]
 
 #![allow(box_pointers)]
 #![allow(dead_code)]

colmeia-hyperstack/src/hyperstack.rs

@@ -6,7 +6,6 @@ use async_std::{
     task,
 };
 use colmeia_hyperdrive::Hyperdrive;
-use colmeia_hyperswarm_dht::Config;
 use ed25519_dalek::PublicKey;
 use futures::{Future, Stream, StreamExt};
 use hypercore_protocol::ProtocolBuilder;
@@ -72,7 +71,7 @@ where
         let mut mdns = colmeia_hyperswarm_mdns::MdnsDiscovery::new();
         mdns.with_announcer(self.listen_address.port())
             .with_locator(Duration::from_secs(60)); // TODO: config
-        mdns.add_topic(&hypercore_protocol::discovery_key(self.key.as_bytes()))
+        mdns.add_topic(hypercore_protocol::discovery_key(self.key.as_bytes()))
             .await?;
         Ok(mdns)
     }

colmeia-hyperswarm-mdns/src/locator.rs

@@ -160,10 +160,10 @@ fn select_ip_from_hyperswarm_mdns_response(
         let port = srv_data.port();
         if srv_data.target() == &*crate::UNSPECIFIED_NAME {
             return Some(SocketAddr::new(IpAddr::V4(*origin_ip), port));
-        } else {
-            let target_ipv4 = srv_data.target().to_utf8().parse::<Ipv4Addr>().ok()?;
-            return Some(SocketAddr::new(IpAddr::V4(target_ipv4), port));
         }
+
+        let target_ipv4 = srv_data.target().to_utf8().parse::<Ipv4Addr>().ok()?;
+        return Some(SocketAddr::new(IpAddr::V4(target_ipv4), port));
     }
     None
 }