Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for nested modules #152

Merged
merged 10 commits into from
Sep 19, 2023

Conversation

gerblesh
Copy link
Contributor

fingers crossed this actually builds

@gerblesh gerblesh marked this pull request as ready for review September 16, 2023 07:17
@gerblesh gerblesh requested a review from castrojo as a code owner September 16, 2023 07:17
@gerblesh
Copy link
Contributor Author

gerblesh commented Sep 16, 2023

marked as ready as i'm pretty positive builds work now, might want to add documentation on this as well, the current default setup is to derive the modules from modules.yml, but feel free to change that. I just did it to test out the nesting functionality

@xynydev
Copy link
Member

xynydev commented Sep 18, 2023

Looks good and really clean. I would leave out the modules.yml though and just keep the inline modules. This also needs docs, but I can do that if you're more comfortable with that.

@gerblesh
Copy link
Contributor Author

ok moved back to the older recipe.yml configuration, also corrected a typo

@gerblesh gerblesh enabled auto-merge September 19, 2023 04:53
@gerblesh gerblesh disabled auto-merge September 19, 2023 04:55
@gerblesh gerblesh enabled auto-merge (squash) September 19, 2023 04:59
@gerblesh gerblesh merged commit aee351f into blue-build:template Sep 19, 2023
1 check passed
vietchinh pushed a commit to vietchinh/ulightblue that referenced this pull request Sep 19, 2023
* feat: add support for nested modules

* chore: test out module nesting

* fix: made build function

* revert: move back to old recipe.yml configuration

* fix: formatting in recipe.yml

* style: add newline between modules
tulilirockz pushed a commit to tulilirockz/Malachite that referenced this pull request Sep 21, 2023
* feat: add support for nested modules

* chore: test out module nesting

* fix: made build function

* revert: move back to old recipe.yml configuration

* fix: formatting in recipe.yml

* style: add newline between modules
tulilirockz pushed a commit to tulilirockz/Malachite that referenced this pull request Sep 21, 2023
* feat: add support for nested modules

* chore: test out module nesting

* fix: made build function

* revert: move back to old recipe.yml configuration

* fix: formatting in recipe.yml

* style: add newline between modules
RoyalOughtness referenced this pull request in secureblue/secureblue Sep 21, 2023
* feat: add support for nested modules

* chore: test out module nesting

* fix: made build function

* revert: move back to old recipe.yml configuration

* fix: formatting in recipe.yml

* style: add newline between modules
@gerblesh gerblesh deleted the nested-modules branch October 20, 2023 20:52
RoyalOughtness referenced this pull request in secureblue/secureblue Nov 27, 2023
* feat: add support for nested modules

* chore: test out module nesting

* fix: made build function

* revert: move back to old recipe.yml configuration

* fix: formatting in recipe.yml

* style: add newline between modules
RoyalOughtness referenced this pull request in secureblue/secureblue Nov 27, 2023
* feat: add support for nested modules

* chore: test out module nesting

* fix: made build function

* revert: move back to old recipe.yml configuration

* fix: formatting in recipe.yml

* style: add newline between modules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants