Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: versioning modules #240

Merged
merged 37 commits into from
Aug 11, 2024
Merged

feat: versioning modules #240

merged 37 commits into from
Aug 11, 2024

Conversation

xynydev
Copy link
Member

@xynydev xynydev commented May 28, 2024

This PR adds a new GH workflow (build-individual.yml) and an accompanying script (build-individual.nu) that builds modules into separate containers and tags them properly, including building all versions of versioned modules.

A lot is yet unimplemented. Currently the builds are pretty fast even without utilizing GH jobs, since nothing is pushed to the web. I didn't have the energy to bother with figuring out the GHA matrix generation stuff as there were some errors I couldn't solve, so I just though, why not make it all one script lol...

@xynydev xynydev linked an issue May 28, 2024 that may be closed by this pull request
@gmpinder
Copy link
Member

I am in love with nushell purely from seeing it in this PR alone

@xynydev
Copy link
Member Author

xynydev commented Jun 1, 2024

The build-invidual.nu script is functionally done now. Next steps;

  • Secondary script & build to replace the current build.yml
    • This one would generate only one container, ghcr.io/blue-build/modules, with just the latest version of each module.

@xynydev xynydev marked this pull request as ready for review August 10, 2024 12:41
@xynydev xynydev requested a review from fiftydinar as a code owner August 10, 2024 12:41
@xynydev
Copy link
Member Author

xynydev commented Aug 10, 2024

Since modules.json is now handled by the website and the other stuff is handled by CLI, this PR is basically ready now. It is now capable of building and tagging the individual module containers as well as a unified module container containing the latest version of every official module.

Reviews from all appreciated, @gmpinder as the CLI implementer should take a closer look. After this is merged we can start implementing default-flatpaks v2 with @fiftydinar. I'll move the other TODO items in my last post to the tracking issue #208.

Edit:
I decided to keep the v1 folder in default-flatpaks, because we're likely to make v2 soon, and that serves as a good starting point to using versioning. It's also a good test for the functionality in this PR.

@xynydev xynydev requested a review from gmpinder August 10, 2024 12:46
@xynydev xynydev mentioned this pull request Aug 10, 2024
Copy link
Member

@gmpinder gmpinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do a deeper review when I'm at my computer

@xynydev
Copy link
Member Author

xynydev commented Aug 11, 2024

@fiftydinar final approves for this so we can merge?

@xynydev xynydev merged commit ea2720b into main Aug 11, 2024
@xynydev xynydev deleted the 208-feat-versioning-modules branch August 11, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: versioning modules
3 participants