-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): add POST method that will add a uuid #8
Conversation
Francis made a good observation that the generated uuid isn't returned to the client. Looking. |
Okay added a header that will return the ObjectLocation. Need to figure out how to test it - we can deploy/test by hand but if any guidance lmk. |
Linting fails on this, can't reproduce locally. Looking... Here is from my local run.
It's different version local. Maybe will try updating. |
I fixed the linting issue w/ the version changes but yaegi's testing fails to locate the vendored dependency (uuid) |
…encies in pipeline
I checked what another plugin is doing - if you can approve this to get it running would appreciate it! Also, I checked and Traefik is using go 1.21 in its pipeline. Hopefully no issue if we do too. |
.github/workflows/build.yaml
Outdated
@@ -35,6 +35,14 @@ jobs: | |||
- name: Set up GOPATH | |||
run: go env -w GOPATH=${{ github.workspace }}/go | |||
|
|||
|
|||
- name: Check and get dependencies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Offset seems wrong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks - Fixed. was hoping to iterate on it on my fork first. Don't have admin access but I think there is a toggle to allow forks to run the workflow.
LGTM |
@francisf2 @ilaidlaw can I have write access to this project? |
(Intended to be published at 0.2.0).
This adds a
POST
method that will append/$UUID
to the path.It vendorizes the google uuid plugin as required by traefik.
Not sure if it works (how do I test it?), looks okay tho! We added it to Yoel's repo.