-
Notifications
You must be signed in to change notification settings - Fork 23
Close #53 - Add PUT multipart support #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
devscripts's salsa support ~ https://salsa.debian.org/debian/devscripts/-/merge_requests/311 |
Using GitLab's API v4, it is possible to change a project's avatar. However the request needs to be submitted via PUT with `Content-Type: multipart/form-data` header set. REF: https://docs.gitlab.com/ee/api/projects.html#upload-a-project-avatar
Split edit_project -> edit_project_multipart
To me, this doesn't align with the function naming convention, but I couldn't see an elegant way of handling it with |
Submitted this to Debian's package ~ https://salsa.debian.org/perl-team/modules/packages/libgitlab-api-v4-perl/-/merge_requests/1 |
$ perl generate.pl > ../lib/GitLab/API/v4.pm To me, this doesn't align with the function naming convention, but I couldn't see an elegant way of handling it with generate.pl
Sorry for very late reply to this. I'm going to have to review this a bit closer since this is not a straightforward change. For now going to get all the other queued up PRs out then I'll address this one last PR and the open issues for a potential future release in the coming days. |
Thanks for getting back to me @bluefeet - all good and I totally understand! Is there anything I can do to help? |
To use GitLab's API v4, in order to change a project's avatar, the request needs to be submitted via PUT with
Content-Type: multipart/form-data
header.REF: https://docs.gitlab.com/ee/api/projects.html#upload-a-project-avatar
content-type:
in the request, in order to reduce the amount of libraries neededsub edit_project
, rather than making its a new one (to keep the naming convention)_call_rest_client
happens twice