mechanism: Do not use eval to retrieve dhcpd handler class

See #416
blueman-project · Dec 18, 2015 · a3845bb · a3845bb
1 parent 27a1d89
commit a3845bb
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/blueman/plugins/mechanism/Network.py b/blueman/plugins/mechanism/Network.py
@@ -10,6 +10,8 @@
 from gi.repository import GObject
 from blueman.main.NetConf import NetConf, DnsMasqHandler, DhcpdHandler
 
+DHCPDHANDLERS = {"DnsMasqHandler": DnsMasqHandler,
+                 "DhcpdHandler": DhcpdHandler},
 
 class Network(MechanismPlugin):
     @dbus.service.method('org.blueman.Mechanism', in_signature="s", out_signature="s", sender_keyword="caller",
@@ -53,7 +55,7 @@ def SetGN(self, enabled, caller):
     def EnableNetwork(self, ip_address, netmask, dhcp_handler, caller):
         nc = NetConf.get_default()
         nc.set_ipv4(ip_address, netmask)
-        eval("nc.set_dhcp_handler(%s)" % dhcp_handler)
+        nc.set_dhcp_handler(DHCPDHANDLERS[dhcp_handler])
         nc.apply_settings()
 
     @dbus.service.method('org.blueman.Mechanism', in_signature="", out_signature="", sender_keyword="caller")