New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move all build time constants to a json file #1951

Draft

infirit wants to merge 3 commits into blueman-project:main from infirit:settings

Contributor

infirit commented Nov 28, 2022 •

edited

Loading

Say bye Constants.py 👋. Putting it out here as draft to get feedback and have mypy yell at me. This is a big(ish) change so ig this is to be merged let's wait for 2.5.

todo:

Fix some leftovers I just noticed for handling the uipath that was dropped with gresource
Almost certainly deal with mypy and other tests
do some proper testing
I noticed we don't use a couple constants so also review them
anything else that comes up
Remove autotools and update path handling for meson (can do in separate PR)
- use meson build dir
- automatically detect we run in a meson builddir

infirit added 2 commits

November 28, 2022 21:56


          Also check for cython3


          launch: move constants to the caller

9c9c07b

infirit force-pushed the settings branch 2 times, most recently from cdafedc to cb9acf5 Compare

November 30, 2022 23:35


          Replace generated Constants.py with a simple json file

7b8f714

infirit force-pushed the settings branch from cb9acf5 to 7b8f714 Compare

November 30, 2022 23:40

sonarqubecloud bot commented Nov 30, 2022

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
0.0% Duplication

github-actions bot added the stale label

github-actions bot closed this

cschramm removed the stale label

cschramm reopened this

sonarqubecloud bot commented Mar 1, 2024

Quality Gate passed

Issues
7 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet