Make search button a toggle #2053
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infirit
force-pushed
the
searchbuttonstop
branch
from
03eed2f to
df17ba9
Compare
infirit
force-pushed
the
searchbuttonstop
branch
from
597510f to
c4027d4
Compare
|
I like it. 👍 Brings us a little closer to also drop the timeout mechanism, but it would need some animation other than the progress bar, I guess. That stop icon's border looks like it could be spinning. 😅 |
|
Kudos, SonarCloud Quality Gate passed!
|
|
How about a spinner like this. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still need to clean it up and drop the stop from the progressbar but putting it here for some feedback.
edit: updated screenhot and hid the cancel button