Rename recent connections header #2364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You dropped the accelerator in the string not sure if you intended this. If not let's do |
|
I think an accelerator is pointless for the insensitive item, isn't it? |
infirit
approved these changes
May 15, 2024
|
It doesn't which make me wonder why it was there in the first place lol. |
I hope this makes things clearer and avoids confusion due to the change from 2.3 to 2.4. Closes blueman-project#2328
|
It used to make sense when the item had a submenu and we just didn't remove the accelerator (which also made sense to not mess up translations). |
|
Merged
cschramm
added a commit
to cschramm/blueman
that referenced
this pull request
Sep 8, 2024
I hope this makes things clearer and avoids confusion due to the change from 2.3 to 2.4. Closes blueman-project#2328
infirit
pushed a commit
to infirit/blueman
that referenced
this pull request
Sep 19, 2024
I hope this makes things clearer and avoids confusion due to the change from 2.3 to 2.4. Closes blueman-project#2328
infirit
pushed a commit
that referenced
this pull request
Sep 27, 2024
I hope this makes things clearer and avoids confusion due to the change from 2.3 to 2.4. Closes #2328
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope this makes things clearer and avoids confusion due to the change from 2.3 to 2.4.
Closes #2328