Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add EXT-X-KEY tag support to playlist parser #201

Merged
merged 3 commits into from
Dec 15, 2024
Merged

Conversation

Lysander66
Copy link
Contributor

Media Segments MAY be encrypted.

Add support for EXT-X-KEY tag in m3u8 playlist parser.

Ref: https://datatracker.ietf.org/doc/html/rfc8216#section-4.3.2.4

@aler9
Copy link
Member

aler9 commented Dec 14, 2024

Hello, thanks for this patch, just fix lint errors and add a couple of tests and it will be merged.

@Lysander66
Copy link
Contributor Author

Hello, thanks for this patch, just fix lint errors and add a couple of tests and it will be merged.

Hi, I've fixed the lint errors and added the test cases for EXT-X-KEY tag with different scenarios.

Copy link

codecov bot commented Dec 14, 2024

Codecov Report

Attention: Patch coverage is 80.51948% with 15 lines in your changes missing coverage. Please review.

Project coverage is 73.27%. Comparing base (047a1d4) to head (2d8d50e).

Files with missing lines Patch % Lines
pkg/playlist/media_key.go 80.32% 8 Missing and 4 partials ⚠️
pkg/playlist/media.go 81.25% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #201      +/-   ##
==========================================
+ Coverage   73.15%   73.27%   +0.11%     
==========================================
  Files          57       58       +1     
  Lines        3975     4052      +77     
==========================================
+ Hits         2908     2969      +61     
- Misses        870      882      +12     
- Partials      197      201       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aler9 aler9 merged commit 030bcdd into bluenviron:main Dec 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants