Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: frontend: explanatory diagrams: use themeable colours #2787

Open
1 task done
ES-Alexander opened this issue Jul 5, 2024 · 0 comments
Open
1 task done

core: frontend: explanatory diagrams: use themeable colours #2787

ES-Alexander opened this issue Jul 5, 2024 · 0 comments
Assignees
Labels
accessibility core Issue related to BlueOS-core enhancement New feature or request triage Needs triage from developers ui User Interface feature

Comments

@ES-Alexander
Copy link
Collaborator

ES-Alexander commented Jul 5, 2024

Current behaviour

SVGs provided in #2748 and #2760 use hardcoded colour values, both within the SVGs and for the dynamic (light/dark) outline handling. These colours fit the SMS vision, and work well with our default theme, but may not play as nicely with custom themes (see #1938).

Expected or desired behaviour

It would be nice if

  1. the themes were updated to include the new image colours
    1. SMS should probably provide names for the defaults
    2. The new variables could be something like:
      • outline (dark-mode): #D1EAF1
      • outline (light-mode): #002F45
      • water: #2599D1 (almost BR_BLUE?)
      • positive: #4DA383
      • neutral: #FF9A00
      • negative: #FF00DE
      • attention: #FDDC00 (almost TETHER_YELLOW?)
  2. the SVGs were modified to make use of theme-based colours via CSS variables, instead of hardcoded hex codes
    • e.g. style="fill:var(--outline);" (I think?)
    • This would also remove the current light/dark outline colour switching mechanism, as it would be redundant
      • Note that failsafes and motor-reversal both implement the colour switching, so that should at least be consolidated, but can ideally be removed from both

Prerequisites

  • I have checked to make sure that a similar request has not already been filed or fixed.
@ES-Alexander ES-Alexander added enhancement New feature or request core Issue related to BlueOS-core ui User Interface feature triage Needs triage from developers labels Jul 5, 2024
@ES-Alexander ES-Alexander self-assigned this Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility core Issue related to BlueOS-core enhancement New feature or request triage Needs triage from developers ui User Interface feature
Projects
None yet
Development

No branches or pull requests

1 participant