Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add watch to interactions, send feed with interactions #3448

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add watch to interactions, send feed with interactions #3448

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion lexicons/app/bsky/feed/defs.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,13 +243,18 @@
"app.bsky.feed.defs#interactionRepost",
"app.bsky.feed.defs#interactionReply",
"app.bsky.feed.defs#interactionQuote",
"app.bsky.feed.defs#interactionShare"
"app.bsky.feed.defs#interactionShare",
"app.bsky.feed.defs#interactionVideoWatch"
]
},
"feedContext": {
"type": "string",
"description": "Context on a feed item that was originally supplied by the feed generator on getFeedSkeleton.",
"maxLength": 2000
},
"videoWatchMs": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to use a more generic name here ?

For example: interactionDurationMs could also be for interactionSeen. This metric could also be usefull if we add an interaction that describes how long the user spent reading the responses threads.

"type": "integer",
"description": "Time (in milliseconds) that has been spent watching a video, including time spent watching loops of the video. Should only be included when sending a video watch interaction."
}
}
},
Expand Down Expand Up @@ -308,6 +313,10 @@
"interactionShare": {
"type": "token",
"description": "User shared the feed item"
},
"interactionVideoWatch": {
"type": "token",
"description": "User watched the video in the feed item"
}
}
}
7 changes: 6 additions & 1 deletion lexicons/app/bsky/feed/sendInteractions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,19 @@
"encoding": "application/json",
"schema": {
"type": "object",
"required": ["interactions"],
"required": ["interactions", "feed"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is not backwards compatible. not sure if that matters though.

"properties": {
"interactions": {
"type": "array",
"items": {
"type": "ref",
"ref": "app.bsky.feed.defs#interaction"
}
},
"feed": {
"type": "string",
"format": "at-uri",
"description": "The feed for which the interactions are being sent"
}
}
}
Expand Down