PDS: ActorStore Refactor #3492
Merged
PDS: ActorStore Refactor #3492
+522
−530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthieusieben
force-pushed
the
msi/refactor-actor-store-reader
branch
5 times, most recently
from
5dc7b4d to
cb70e9e
Compare
matthieusieben
force-pushed
the
msi/refactor-actor-store-reader
branch
from
cb70e9e to
01c11c6
Compare
rafaelbsky
approved these changes
Feb 4, 2025
- Removing `DetailedAccountStore` class (moving its logic inside `AccountManager`) - Factorizes image URL building into its own class (for easy re-use from `AccountManager`) - Adds an `AppView` class that exposes an `agent: AtpAgent` and url builder function (used by the `ImageUrlBuilder`). - Reworks the `ActorStore` to avoid circular dependency between `AccountManager` and `LocalViewerCreator` (needed because of first item)
matthieusieben
force-pushed
the
msi/refactor-actor-store-reader
branch
from
01c11c6 to
0dbb458
Compare
matthieusieben
force-pushed
the
msi/refactor-actor-store-reader
branch
from
db1e3ca to
4924bc6
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes essentially allow to access the
ActorStorefrom theAccountManagerclass. This enables accessing the user's profile record from the OAuth Provider. These changes are needed to avoid code duplication (for getting the user profile, and building the profile url) when building the account data needed by the OAuth UI.Note
This PR is a prerequisite for #2945
This PR simplifies the code of the
pdspackage by:DetailedAccountStoreclass (merging its logic insideAccountManager)ActorStoreto avoid circular dependency betweenAccountManagerandLocalViewerCreator, caused by previous point.ImageUrlBuilderclass (to avoid code duplication inAccountManager&LocalViewer)BskyAppViewclass that exposes anagent: AtpAgentand image url builder function (used by theImageUrlBuilder).dbproperty ofActorStoreReaderasprotected, preventing its (unsafe) use from outside the class. This change also caused several small utilities to be moved in the actor-store "reader classes" (actor-store/*/reader.ts).