❇️ Subject priority score #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -613,7 +621,12 @@ function Form( | |||
|
|
|||
| {!!subjectStatus && ( | |||
| <div className="pb-4"> | |||
| <p> | |||
| <p className="flex flex-row items-center"> | |||
| {!!subjectStatus?.priorityScore && ( | |||
There was a problem hiding this comment.
Does 0 means low priority ? If so, it might make sense to distinguish null here:
Suggested change
| {!!subjectStatus?.priorityScore && ( | |
| {subjectStatus?.priorityScore != null && ( |
There was a problem hiding this comment.
0 means either we haven't set a priority or we have intentionally set it to 0. it always defaults to 0 either way and never null and we won't care why it's 0.
Comment on lines
+12
to
+14
| if (!priorityScore) { | ||
| return null | ||
| } |
There was a problem hiding this comment.
Since priorityScore is not optional, does it make sense to not render when priorityScore is 0 (low priority) ?
Suggested change
| if (!priorityScore) { | |
| return null | |
| } |
There was a problem hiding this comment.
we don't have a use case where 0 priority score needs to be taken into account by mods so a non-positive integer does not need to be rendered.
matthieusieben
approved these changes
Feb 6, 2025
arcalinea
temporarily deployed
to
add-priority-score - ozone-staging PR #287
Render
Destroyed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on bluesky-social/atproto#3495
This PR adds priority score event display and sorting and filtering the queue by priority score.