Bsky short link service #4542
Merged
Bsky short link service #4542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-4542.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cpo9nq6ehbks73b4d4ug. |
|
haileyok
approved these changes
Jun 20, 2024
haileyok
reviewed
Jun 20, 2024
haileyok
reviewed
Jun 20, 2024
Comment on lines
+314
to
+318
| if req.Method == "GET" && | ||
| strings.LastIndex(strings.TrimRight(req.URL.Path, "/"), "/") == 0 && // top-level path | ||
| !strings.HasPrefix(req.URL.Path, "/_") { // e.g. /_health endpoint | ||
| return false | ||
| } |
There was a problem hiding this comment.
just to verify, we're okay with these not having some identifying prefix right? ik that came up in discussions though we definitely didn't want it to be a path like /i/abcdef
pfrazee
reviewed
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Included here is a postgres-backed node service for generating short links.
API Usage
POST /linkGenerates a short link for a given path. A given path always produces the same short link, up to some path normalization. Currently only paths to starter packs which contain the actor's DID (rather than handle) are supported, e.g.
/start/did:plc:example/3kv5iwj3csz2p.Request
{ "path": "/start/did:plc:example/3kv5iwj3csz2p" }Response
{ "url": "https://link.bsky.app/6H8uqD" }GET /:linkIdThis endpoint represents the short link itself. It generates a 301 permanent redirect to the original link. Query parameters are preserved. If the link id is not familiar, a temporary 303 redirect to the app's homepage is served.