Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALF TabBar #6924

Merged
merged 2 commits into from
Dec 3, 2024
Merged

ALF TabBar #6924

merged 2 commits into from
Dec 3, 2024

Conversation

mozzius
Copy link
Member

@mozzius mozzius commented Dec 3, 2024

Should broadly be the same as before, except I've reduced the height of the indicator by 1px (so it's now 2px tall)

Test plan

Check it still all works on web and on native

@arcalinea arcalinea temporarily deployed to samuel/alf-tabbar - social-app PR #6924 December 3, 2024 17:39 — with Render Destroyed
@arcalinea arcalinea temporarily deployed to samuel/alf-tabbar - social-app PR #6924 December 3, 2024 17:41 — with Render Destroyed
Copy link

github-actions bot commented Dec 3, 2024

Old size New size Diff
8.14 MB 8.14 MB 0 B (0.00%)

Copy link
Member

@estrattonbailey estrattonbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested on iOS only

@mozzius mozzius merged commit 79f807d into main Dec 3, 2024
6 checks passed
@mozzius mozzius deleted the samuel/alf-tabbar branch December 3, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants