Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine plural marks #7065

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Refine plural marks #7065

merged 1 commit into from
Dec 12, 2024

Conversation

quiple
Copy link
Contributor

@quiple quiple commented Dec 12, 2024

  • Refines plural marks to reduce the length of strings used for translation.
    • Translations are still free to rearrange words.
    • NotificationFeedItem.tsx, src/screens/StarterPack/Wizard/index.tsx, etc. are already written this way.
  • In src/components/LabelingServiceCard/index.tsx, replaces count with likeCount to consolidate the translation string.
  • In src/view/com/util/post-ctrls/RepostButton.tsx, provides the full string to the translation so it can be contextualized.

@gaearon gaearon merged commit 084905c into bluesky-social:main Dec 12, 2024
6 checks passed
auroursa added a commit to auroursa/bsky-app-zh that referenced this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants