-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create status page PR2 #1494
Open
jennifer-gan
wants to merge
40
commits into
develop
Choose a base branch
from
feat/fe/statuspage-3
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Create status page PR2 #1494
Changes from all commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
136ed04
- Update status home page to connect to create status page
jennifer-gan 4345d69
- Fix the checkbox position to be conditional on non string label
jennifer-gan 5adffd8
- WIP general setting panel
jennifer-gan 2405d01
- update to match BE
jennifer-gan 8506291
- Fix the component not showing the file text and logo section issue
jennifer-gan df36f87
- Add log and general settins tab validation
jennifer-gan 5df7ddb
- WIP Replace Field with TextInput , HttpAdornment seems not working
jennifer-gan 0759b16
- add lower case first letter string util func
jennifer-gan cc2187d
- add routes to status page nested pages
jennifer-gan b275bdc
- Link general settings and contens to status page in navigation
jennifer-gan 35a981a
- Update icons etc
jennifer-gan b651369
- WIP Server list tab
jennifer-gan cbec5fd
- Change "Next" to "Save"
jennifer-gan 2825ff4
- WIP contents tab adding servers list
jennifer-gan 03ce805
- Add React DND related libraries
jennifer-gan b1f0568
- Created Card type
jennifer-gan 1ab4bd7
Merge branch 'develop' into feat/fe/statuspage-3
jennifer-gan 9370db6
- Fix the suburl prefix via extending existing HttpAdorment
jennifer-gan 00be6c2
- Fix the warning button can not be descendant of button
jennifer-gan c61d1ac
Merge branch 'develop' into feat/fe/statuspage-3
jennifer-gan 9d212c9
Merge branch 'develop' into feat/fe/statuspage-3
jennifer-gan fdca92e
Merge branch 'develop' into feat/fe/statuspage-3
jennifer-gan 406fa6e
- Merge feedback works from status page 1 and status page 2 branches
jennifer-gan c1dc049
- Remove nested routes for tabs
jennifer-gan 8292654
- Add context provider for both tabs
jennifer-gan 5045eaf
- useContext from parent page for form fields
jennifer-gan 219bcd4
- Add GetStatusPageByUrl to networkservice
jennifer-gan c9b804a
- Update getStatusPageByUrl to match BE
jennifer-gan 3a00742
Merge branch 'develop' into feat/fe/statuspage-3
jennifer-gan 11154ad
- Code clean up
jennifer-gan feaf1e3
Merge branch 'develop' into feat/fe/statuspage-3
jennifer-gan c535a6f
- Update path
jennifer-gan d844078
- Update validation
jennifer-gan 23d97f8
- Replace Doc icon with Reorder icon
jennifer-gan a5df7be
- Create new status page and retrieval are now working end to end, ex…
jennifer-gan d8da182
Merge branch 'develop' into feat/fe/statuspage-3
jennifer-gan 1206451
- Update JSDoc
jennifer-gan 8b72f84
- Update logo handling and validation
jennifer-gan 5226f3c
- Update to add status page subdomain as env variable
jennifer-gan a544a0f
Merge branch 'develop' into feat/fe/statuspage-3
jennifer-gan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,2 @@ | ||
VITE_APP_API_BASE_URL=UPTIME_APP_API_BASE_URL | ||
VITE_STATUS_PAGE_SUBDOMAIN_PREFIX=UPTIME_STATUS_PAGE_SUBDOMAIN_PREFIX |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Possible JSDoc mismatch
This line's documentation calls
isRound
a string, but it is declared and used as a boolean. Updating the JSDoc to reflect a boolean type prevents confusion.📝 Committable suggestion