-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace username with name and surname #184
replace username with name and surname #184
Conversation
@erenfn I changed username to name and surname in backend too and hence on frontend where it is used. |
I have created a PR for your branch with some fixes. The last thing to do is to change |
Thank you for your contribution @mr-loop-1 |
@erenfn now I saw your pr but it was closed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do not delete username from the table
It is still open, but you may need to merge it since you made a change afterwards. |
@uparkalau @erenfn do we need username field too with surname and name |
Yes keep username do not delete it |
then I guess it would be a unique identifier like email. Btw what would be displayed on Header/dashboard and stored in cookies, the name+surname or username |
Replaces the username field with name and surname in the application