Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace username with name and surname #184

Merged
merged 6 commits into from
Sep 6, 2024

Conversation

mr-loop-1
Copy link
Contributor

Replaces the username field with name and surname in the application

@mr-loop-1 mr-loop-1 changed the title add surname field on signup page replace username with name and surname Sep 5, 2024
@mr-loop-1
Copy link
Contributor Author

#181 (comment)

@erenfn I changed username to name and surname in backend too and hence on frontend where it is used.

@erenfn erenfn self-requested a review September 5, 2024 12:01
@erenfn
Copy link
Collaborator

erenfn commented Sep 5, 2024

I have created a PR for your branch with some fixes. The last thing to do is to change frontend/src/tests/scenes/CreateAccountPage.test.jsx

@gorkem-bwl
Copy link
Contributor

Thank you for your contribution @mr-loop-1

@mr-loop-1 mr-loop-1 marked this pull request as ready for review September 5, 2024 17:55
@mr-loop-1
Copy link
Contributor Author

@erenfn now I saw your pr but it was closed

Copy link
Contributor

@uparkalau uparkalau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not delete username from the table

@erenfn
Copy link
Collaborator

erenfn commented Sep 5, 2024

@erenfn now I saw your pr but it was closed

It is still open, but you may need to merge it since you made a change afterwards.

@mr-loop-1
Copy link
Contributor Author

mr-loop-1 commented Sep 6, 2024

do not delete username from the table

@uparkalau @erenfn do we need username field too with surname and name

@uparkalau
Copy link
Contributor

do not delete username from the table

@uparkalau @erenfn do we need username field too with surname and name

Yes keep username do not delete it

@mr-loop-1
Copy link
Contributor Author

Yes keep username do not delete it

then I guess it would be a unique identifier like email. Btw what would be displayed on Header/dashboard and stored in cookies, the name+surname or username

@erenfn erenfn merged commit fedad32 into bluewave-labs:develop Sep 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants