Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update seeders to use hashed password #268

Conversation

parthmanhas
Copy link
Contributor

line 35 bcrypt comparison is breaking due to storage of unhashed password in db

image

@parthmanhas parthmanhas closed this Oct 6, 2024
@parthmanhas parthmanhas deleted the update-seeders-to-use-hashed-password branch October 6, 2024 12:52
Copy link
Contributor

coderabbitai bot commented Oct 6, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request introduces several modifications across multiple files in the backend and frontend. Key changes include the implementation of user data seeding with hashed passwords, the addition of new components for profile settings, modals for image uploads and account deletions, and enhancements to existing components for improved navigation. Notably, the routing structure is expanded to accommodate a new profile settings page, and new styles are introduced for various components to enhance their layout and presentation.

Changes

File Path Change Summary
backend/seeders/20240610054534-demo-users.js Added bcrypt for password hashing, renamed username to name, updated user passwords, modified deletion target in down method.
frontend/package.json Added dependency "react-dropzone": "^14.2.9".
frontend/src/App.jsx Added new route for ProfileSettingsPage at /profile-settings.
frontend/src/components/DropdownMenu/DropdownMenu.jsx Introduced handleNavigation function for "Profile" and "Settings" menu items, linking to /profile-settings.
frontend/src/components/Modals/DeleteConfirmationModal/DeleteConfirmationModal.jsx Added DeleteConfirmationModal component for account deletion confirmation.
frontend/src/components/Modals/DeleteConfirmationModal/DeleteConfirmationModal.module.scss Created styles for DeleteConfirmationModal.
frontend/src/components/Modals/UploadImageModal/UploadModal.jsx Introduced UploadModal component for image uploads with drag-and-drop functionality.
frontend/src/components/Modals/UploadImageModal/UploadModal.module.scss Created styles for UploadModal.
frontend/src/components/Profile/Profile.jsx Added Profile component for user profile management, including modals for image upload and account deletion.
frontend/src/components/Profile/Profile.module.scss Created styles for Profile component.
frontend/src/components/TextFieldComponents/CustomTextField/CustomTextField.jsx Updated CustomTextField to include new prop labelSubText.
frontend/src/scenes/ProfileSettings/ProfileSettings.module.scss Created styles for ProfileSettings component.
frontend/src/scenes/ProfileSettings/ProfileSettingsPage.jsx Introduced ProfileSettingsPage component for managing profile settings.

Possibly related PRs

  • Develop #177: The changes in the CreateAccountPage.jsx file involve renaming the username field to name, which directly relates to the renaming of the username field to name in the main PR's seeder file.

Suggested labels

backend, frontend


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant