Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#34 - Add routing tools #64

Merged
merged 17 commits into from
Aug 20, 2024
Merged

#34 - Add routing tools #64

merged 17 commits into from
Aug 20, 2024

Conversation

PiotrFedak
Copy link
Contributor

This PR aims to combine methods from HttpRequest, HttpResponse, Session, Authentication and Translation to better reflect the Routing trait.

This should close #34

@PiotrFedak PiotrFedak requested review from EwelinaSkrzypacz and removed request for EwelinaSkrzypacz June 27, 2024 08:06
@JakubKermes JakubKermes mentioned this pull request Jul 8, 2024
@EwelinaSkrzypacz EwelinaSkrzypacz deleted the #34-Add-routing-tools branch July 9, 2024 10:47
@EwelinaSkrzypacz
Copy link
Member

EwelinaSkrzypacz commented Jul 9, 2024

Sorry, by mistake I closed this

@EwelinaSkrzypacz EwelinaSkrzypacz restored the #34-Add-routing-tools branch July 9, 2024 10:48
@PiotrFedak PiotrFedak marked this pull request as ready for review August 8, 2024 21:55
@EwelinaSkrzypacz
Copy link
Member

Please resolve conflicts

Copy link
Member

@EwelinaSkrzypacz EwelinaSkrzypacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. In documentation, in Overview section, the Routing is missing

image

  1. In the menu Routing is on the end but I noticed that all options are sorted alphabetically

image

  1. Please look at the video below - when I want to see PHP code, in one case, the content stretches 👇
simplescreenrecorder-2024-08-13_07.10.57.mp4

Added missing Routing in Overview section
Sorted alphabetically
Fixes bug with stretching content
@PiotrFedak PiotrFedak merged commit f50c831 into main Aug 20, 2024
2 checks passed
@PiotrFedak PiotrFedak deleted the #34-Add-routing-tools branch August 20, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add routing tools
2 participants