Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapsing Sidebery #158

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Collapsing Sidebery #158

wants to merge 5 commits into from

Conversation

louie-velarde
Copy link

uc.tweak.collapse-sidebery
Collapsing / expanding vertical tab bar (via Sidebery) like in Edge

Not compatible with uc.tweak.rounded-corners

Copy link
Owner

@bmFtZQ bmFtZQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the most part, mostly just some changes regarding the configuration file and moving the sidebery-collapsed.css code into the sidebery.css file.

I might try to add support for the rounded corners tweak myself at a later date.

}
}

:root:not([customizing]):has(#sidebar-title[value="Sidebery"]:not([hidden])),
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be best to change this to use the same selector as above, #sidebar-box[sidebarcommand="_3c078156-979c-498b-8990-85f7987dd929_-sidebar-action"] as the panel name can be arbitrary based on user settings.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@@ -0,0 +1,57 @@
@-moz-document regexp("^moz-extension://.*?/sidebar/sidebar.html") {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The contents of the collapsed file could probably just be added to the end of the sidebery.css file instead of having two separate files.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged into sidebery.css

sidebery.json Outdated
"ctxMenuNative": true,
"navBarLayout": "hidden",
"updateSidebarTitle": true,
"ctxMenuNative": false,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there any specific reason to use the non-native context menu by default? I think the default option should probably be to use the native menu as it seemed to work better most of the time.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an issue with the way I use Sidebery. In any case, I have removed settings that may be specific to the way I use Sidebery.

sidebery.json Outdated
"subPanelRecentlyClosedBar": false,
"subPanelBookmarks": false,
"subPanelHistory": false,
"showNewTabBtns": true,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would probably leave the new tab button enabled by default, as that is what Edge displays.

sidebery.json Outdated
"theme": "proton",
"colorScheme": "ff"
},
"ver": "5.1.1"
}
"sidebar": {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the reason for adding these panels? As far as I know most of these are there by default?

@@ -2,3 +2,4 @@
@import url("content/common.css");
@import url("content/newtab.css");
@import url("tweaks/sidebery.css") (-moz-bool-pref: "uc.tweak.theme.sidebery");
@import url("tweaks/sidebery-collapsed.css") (-moz-bool-pref: "uc.tweak.collapse-sidebery");
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you move the collapsed Sidebery code to the sidebery.css file then the import should be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants