Merge pull request #32 from catalyst/HMU37-33

Fix issue with upgrade script using incorrect db method
bmbrands · Jan 4, 2020 · 21c13d8 · 21c13d8
2 parents c6c52e9 + f5bd66c
commit 21c13d8
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/db/upgrade.php b/db/upgrade.php
@@ -82,9 +82,7 @@ function xmldb_local_analytics_upgrade($oldversion) {
 
     if ($oldversion < 2019070801) {
         // Remove 'analytics' from the configuration table.
-        if ($analytics = $DB->get_record('config_plugins', array('plugin' => 'local_analytics', 'name' => 'analytics')) ) {
-            $DB->delete_record('config_plugins', $analytics);
-        }
+        $DB->delete_records('config_plugins', ['plugin' => 'local_analytics', 'name' => 'analytics']);
         upgrade_plugin_savepoint(true, 2019070801, 'local', 'analytics');
     }