Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

38 Migrate output callbacks to hooks #39

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

leonstr
Copy link

@leonstr leonstr commented Jul 2, 2024

Migrate local_analytics_before_http_headers() and
local_analytics_before_footer() to hooks to reflect change in Moodle 4.4 (see MDL-81144).

Proposed fix for #38 for review.

Migrate local_analytics_before_http_headers() and
local_analytics_before_footer() to hooks to reflect change in Moodle
4.4 (see MDL-81144).
@bmbrands
Copy link
Owner

bmbrands commented Jul 3, 2024

Awesome! thanks for your input. I will give it a test as soon as possible and merge it if successful

@bmbrands bmbrands merged commit a4e9733 into bmbrands:master Sep 16, 2024
@leonstr
Copy link
Author

leonstr commented Sep 23, 2024

https://moodledev.io/docs/4.4/apis/core/hooks#example-of-hook-callback-registration

Make sure to handle the during_initial_install case

@aspark21 No handling for the install/upgrade case is required for this plugin (as far as I can tell).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants