Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A script to generate RTL CSS to append #273

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

davidscotson
Copy link
Contributor

This probably needs a fair bit more work. But in case anyone else wants to have a look at it.

It's just a bunch of shell scripts doing stuff with regexes, so it's a bit fragile.

@davidscotson
Copy link
Contributor Author

Note, don't actually commit the config change as-is, that's just to show what you need to do for the output to work in Moodle.

I'm not sure how to set that dynamically (look for a single RTL language being installed?). At the moment you need to comment/uncomment and reload the styles.

@gjb2048
Copy link
Collaborator

gjb2048 commented May 25, 2014

Will this prevent non-Linux developers from compiling the CSS?

@ds125v
Copy link
Collaborator

ds125v commented May 25, 2014

It's fundamentally a bunch of of regex replaces, sed just happened to be the easiest tool for prototyping. If it becomes part of the workflow then something in nodejs for grunt is probably the most appropriate thing.

The svg scripts where originally done in sed for example.

However, I'm waiting to see what Bootstrap upstream do. One of the 3rd party RTL developers suggested that theyshould abandon RTL in core. The argument made absolutely no sense to me, but its possible they decided to follow that advice.

@davidscotson
Copy link
Contributor Author

I've realised this could be simplified a fair bit if I used [dir="rtl"] rather than .dir-rtl on body to target the RTL rules. It looks like Moodle puts the dir attribute on the HTML tag so anyone know why Moodle CSS uses the latter? Just for historical reasons?

@gjb2048
Copy link
Collaborator

gjb2048 commented Jun 3, 2014

Ours is not to reason why but to do and code.

http://about.me/gjbarnard

On 3 June 2014 12:42, David Scotson [email protected] wrote:

I've realised this could be simplified a fair bit if I used [dir="rtl"]
rather than .dir-rtl on body to target the RTL rules. It looks like Moodle
puts the dir attribute on the HTML tag so anyone know why Moodle CSS uses
the latter? Just for historical reasons?


Reply to this email directly or view it on GitHub
#273 (comment)
.

@gjb2048
Copy link
Collaborator

gjb2048 commented Jul 27, 2014

css-flip has been updated, so is this better / worse?

Ref: https://www.npmjs.org/package/grunt-css-flip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants