Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding configuration for endpoints #307

Merged
merged 2 commits into from
Apr 4, 2024
Merged

Conversation

kellrott
Copy link
Member

Adds --endpoint-config and -l flags to server command line to pass configuration parameters to endpoint plugins.

This changes the signature for an endpoint plug in to:

func NewHTTPHandler(client gripql.Client, config map[string]string) (http.Handler, error) 

@matthewpeterkort
Copy link
Collaborator

Screenshot 2024-03-20 at 3 43 22 PM

This PR yields a new non-fatal error for existing grip-endpoints plugins.

@kellrott
Copy link
Member Author

It changes the function signature of the plugin methods. So they need to be upgraded. Example at

func NewHTTPHandler(client gripql.Client, config map[string]string) (http.Handler, error) {

@matthewpeterkort
Copy link
Collaborator

makes more sense. Thank you.

@kellrott kellrott merged commit 87975df into develop Apr 4, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants