This repository has been archived by the owner on Feb 16, 2022. It is now read-only.
Upgrade PgHero, Rails, and Ruby. Use Alpine base image for size #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ran into an error trying to run against PostgreSQL 10.3 due to changes in the stat functions. Upgrading both Rails and PgHero was pretty straight forward so I'm tackling both. I removed rails_12factor as it's no longer necessary with Rails 5, though there are config changes that I've integrated into the config.
The upgrades Ruby to 2.5.0 (or whatever the latest 2.x series is) and switches to an Alpine based image. Using the Debian base image produced a container that was roughly 850MB. Switching to the recommended Alpine image reduced that to ~250MB (3/10th the size).
Loofah had a set of CVEs for cross site scripting issues, none of which should impact pghero.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into an error trying to run against PostgreSQL 10.3 due to changes
in the stat functions. Upgrading both Rails and PgHero was pretty
straight forward so I'm tackling both.
I removed rails_12factor as it's no longer necessary with Rails 5,
though there are config changes that I've integrated into the config.
This upgrades Ruby to 2.5.0 (or whatever the latest 2.x series is) and
switches to an Alpine based image.
Using the Debian base image produced a container that was ~850MB.
Switching to the recommended Alpine image reduced that to ~250MB (3/10th
the size).
Fixes #10